chetachiezikeuzor / Yin-and-Yang-Theme

An Obsidian.md theme with a stark contrast between dark mode and light mode, much like the Yin and Yang symbol ☯️.
Mozilla Public License 2.0
539 stars 42 forks source link

Format Tables with code font & Create adjustable code blocks in Style Settings #16

Closed s-kyy closed 3 years ago

s-kyy commented 3 years ago

Hey thank you for making this theme, I've been enjoying it and what you were able to do with the style settings. Great stuff.

I was wondering if you'd be able to fix how the markdown tables align. Right now, they are rendered with the normal text font, but it would be more aligned in editor mode if it renders in a code font instead. image

Another aspect I'd like for you to have a way to adjust is adjusting code font size and a way to toggle remove the code block borders. The font is too large and looks jarring (to me) in editor mode when it sits in between text: image

Thanks!

In Style Settings: both WYSWIG settings are on (Headings in Editor & Enhanced Editor Typography) Obsidian Version: v0.12.4 Theme Version: 377df43 (commit hash)

chetachiezikeuzor commented 3 years ago

I just had a user bring up this issue and it should be fixed with the latest version! As for the feature requests, I will be looking into adding these features. So you want the ability to change the font size? Does the obsidian font toggle effect code font for you at the moment?

s-kyy commented 3 years ago

Sorry for the late reply. Cheers for being on top of the table issue!

The obsidian font toggle changes the sizes for all fonts together, so while the code font size does shrink, the text font would be too small to read comfortably.

image

chetachiezikeuzor commented 3 years ago

I guess what I can do is just grant the ability to change code font size in Style Settings. What do you think? I'm actually planning out some new Style Settings features so adding this to the list won't be a problem.

s-kyy commented 3 years ago

Yes that's great! Having it as an adjustable setting would make it more customizable for others as well 👍

chetachiezikeuzor commented 3 years ago

Code block custom font size has now been added under Yin and Yang Theme > Minimalize Elements > Code Blocks. 👍