chetanverma16 / react-portfolio-template

Modern React Portfolio Template (FREE)
https://react-portfolio-template.netlify.com/
1.34k stars 586 forks source link

Added the hide blog feature #50

Closed akshidas closed 2 years ago

akshidas commented 2 years ago

Add a new field in the yourData.json named hideBlog which is a boolean field.

In the Header/index.js used logical and operator to hide the navItem

netlify[bot] commented 2 years ago

Deploy Preview for react-portfolio-template ready!

Name Link
Latest commit 4763878534ad26d01c4b77d4d50b94fdc9641d05
Latest deploy log https://app.netlify.com/sites/react-portfolio-template/deploys/62cad30eba9a8f0009f795db
Deploy Preview https://deploy-preview-50--react-portfolio-template.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

chetanverma16 commented 2 years ago

Go ahead And merge Away 🚀

akshidas commented 2 years ago

Go ahead And merge Away rocket

I can't merge this. I don't have write access, only you can merge

Aryan3212 commented 2 years ago

Hi nice job! Just a question, if someone were to put in /blog after the URL, wouldn't the route still exist? We are only removing the button here. Maybe we can work on this enhancement later. A very minor issue tbh, great work on the commit 😄

akshidas commented 2 years ago

Hi nice job! Just a question, if someone were to put in /blog after the URL, wouldn't the route still exist? We are only removing the button here. Maybe we can work on this enhancement later. A very minor issue tbh, great work on the commit 😄

I noticed that too. We could create a new issue for that

Aryan3212 commented 2 years ago

Hi nice job! Just a question, if someone were to put in /blog after the URL, wouldn't the route still exist? We are only removing the button here. Maybe we can work on this enhancement later. A very minor issue tbh, great work on the commit 😄

I noticed that too. We could create a new issue for that

@achu-krishna For sure!

chetanverma16 commented 2 years ago

Yeah, this is a quick fix as of now to hide the blog. but we can surely work later on for a better approach to this problem.

@achu-krishna Nice Work!