search

chetstone / react-native-palette

A library wrapping the Android Palette class to extract colors from an image.
ISC License
73 stars 8 forks source link

RN47.0 has removed `createJSModules` method #7

Closed prscX closed 6 years ago

prscX commented 7 years ago

Hi,

RN47.0 has removed createJSModule method from ReactPackage.java. In order to make it work on Android with RN47.0, I have removed @overide annotation from RNPalettePackage.java class.

Can you please merge and release so that we can seamlessly use this library on RN47.0 and above

Please let me know in case any changes are required

Thanks, Pranav

chetstone commented 7 years ago

Thanks for your PR. I am on vacation at the moment, will take a look when I return.

On Oct 27, 2017, 05:37 -0500, Pranav Raj Singh Chauhan notifications@github.com, wrote:

Hi, RN47.0 has removed createJSModule method from ReactPackage.java. In order to make it work on Android with RN47.0, I have removed @overide annotation from RNPalettePackage.java class. Can you please merge and release so that we can seamlessly use this library on RN47.0 and above Please let me know in case any changes are required Thanks, Pranav You can view, comment on, or merge this pull request online at:   https://github.com/chetstone/react-native-palette/pull/7 Commit Summary

• Update RNPalettePackage.java

File Changes

• M android/src/main/java/io/palette/RNPalettePackage.java (1)

Patch Links:

• https://github.com/chetstone/react-native-palette/pull/7.patch • https://github.com/chetstone/react-native-palette/pull/7.diff

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

prscX commented 7 years ago

Sure @chetstone. Thanks

chetstone commented 6 years ago

Investigating whether this change will break older versions of RN. Testing with the example app using RN 40 seems to work and reports here seem to agree.

prscX commented 6 years ago

Thanks @chetstone for merging the PR

Thanks Pranav