search

chettoy / apexsky

https://apex.chettoy.com
GNU General Public License v3.0
144 stars 81 forks source link

Why is there a HTTP client in module.rs? #124

Closed tr111ple closed 5 months ago

tr111ple commented 5 months ago

https://github.com/chettoy/apexsky/blob/b5a8c6f019d4bfb738de15c8c7859be8ace5491e/apex_dma/lib/skyapex/skyapex-sdk/src/module.rs

Why HTTP client? What's it doing? Why is there obfuscated WASM here? Please tell us.

Jotalz commented 5 months ago

It seems like you are very concerned about the security of them, as I know, there will be separate client web-radars in the future.

chettoy commented 5 months ago

https://github.com/chettoy/apexsky/blob/b5a8c6f019d4bfb738de15c8c7859be8ace5491e/apex_dma/lib/skyapex/skyapex-sdk/src/module.rs

Why HTTP client? What's it doing? Why is there obfuscated WASM here? Please tell us.

Thank you for your question.

Currently, the WebAssembly module does not make any network calls. The HTTP client in module.rs is part of the runtime infrastructure that supports network access, providing functionality similar to other parts of the system. This enables the WebAssembly module to serve as a cross-platform dynamic library, potentially supporting advanced features in the future, such as querying player data via web APIs.

Think of it as analogous to libskyapex.so or skyapex.dll. Your concern is understandable. If you are compiling this project yourself, ensure that the skyapex.wat file in your source matches the one in this repository. If you obtain executable files from other sources, only run them if you trust the source.

For more details about this module, please refer to the discussion in issue #123. As this is a duplicate concern, we will be closing this issue.