search

chetzer-ncpa / ncpaprop-release

Release version of ncpaprop, a command-line package for modeling the propagation of low-frequency acoustic waves in the atmosphere.
Other
14 stars 2 forks source link

ModBB throws error: No parameter 'write_lossless' has been specified! #34

Closed alexjcwitsil closed 1 year ago

alexjcwitsil commented 1 year ago

I recently installed NCPAProp on a shared HPC (Ubuntu 20.04.5 LTS (GNU/Linux 5.4.0-144-generic x86_64)) The installation, as far as I can tell, went on without a hitch (hooray!) However, when trying to run ModBB, I am getting an error.

Specifically, when trying to run:

ModBB --dispersion --dispersion_file test_dispersion.dat --atmosfile NCPA_canonical_profile_zuvwtdp.dat --azimuth 90 --f_min 0.01 --f_step 0.01 --f_max 0.5 --method modess

I get the error:

terminate called after throwing an instance of 'std::invalid_argument' what(): No parameter 'write_lossless' has been specified!

I can run other examples from the manual including examples using Modess so am unsure as to why ModBB is failing.

Thanks in advance for the help!

chetzer-ncpa commented 1 year ago

Issue was due to the Modess library expecting a --write_lossless option, while the more streamlined ModBB calculation doesn't support turning that option on. Added a dummy parameter to eliminate the error. Future refactoring plans will account for this and remove the necessity for the dummy parameter.