hw07 ready for grading

[abishekarun]

Hi @cheung-amanda,

It’s nice to review your homework 7. Your repo is organized. I can find your R script easily. In addition, you have clearly mentioned the workflow. You have also elaborated on the challenges you faced and the resources that helped you in your readme file.

gap_exploratory.R

• Population data of european countries in 2002 was plotted and saved.
• Population vs life expectancy for countries in 2007.
• GdpPercapita vs lifeExp for all continents was plotted and saved.
• Reordered country based on population and saved it as rds file.

gap_statistical.R

• load the reordered data and made a sanity check.
• Linear models are fitted using lm function and they are saved separately..
• 3 Countries in europe with maximum and minimum slopes are plotted.
• I felt you could have analyzed more countries and also could have used better parameter for categorizing the countries as i felt slope doesnt give accurate measure of fit of model.

gap_figures.R

• The europe fit data is plotted for the 3 best and worst countries.

Hw07_automating_data_analysis_pipelines.Rmd

• It was a Nice report. It was great to know about magrittr package.
• All the plots and tables are presented in a nice manner. The flow of the overall document was nice.
• I found that while embedding the image you had used the saved files.You can also assign plots to variables and use them to embed the plots in markdown. This is another way to do the embedding of plots.
• I also felt little bit more annotation was required at some places explaining some of the things that you have done to help the reader follow along.

Makefile

• Clear and organized with a logical flow.

I felt all the data and figures could have been organized in separate folders. It was great to see you mention the links in readme file as it helped to navigate to different files. One small thing I would suggest is to include the links in issue as well. Overall, I think you did a great job. I really enjoyed reviewing your homework.

Cheers Arun

[wswade2]

Hi cheungamanda,

My apologies for the late response. I was looking for an email directing me to this repository but could not find one. I eventually discovered that I do have access to your repo so will send your feedback now. I found that your repo was neatly organized for this assignment, especially considering the number of files that are generated as a byproduct of using make. You also did a great job providing links to the files that I needed to view. Your graphs were extraordinarily colorful and unique. I have not come across these types of graphs even though we have been working with the gapminder dataset for quite some time. For the purpose of peer review, it would be good to not use echo=FALSE in the future so that we can see the code you used to generate the plots. You also performed some neat population growth analyses with accompanying graphs that were facetted by country. I appreciated that the tasks in this homework assignment were demonstrated in a highly visual way.

Wade

[derekcho]

Hi @cheungamanda ! Here are some comments about your hw07:

Three or more scripts, an Rmd, and a Makefile: Yes Starts by downloading data, ends with Rmd: Yes The output of each is the modified input of the previous step: Yes Includes some analysis and at least one figure: Yes Makefile includes all scripts and Rmd with correct dependencies: No (see comments) Makefile runs: Yes

• In your Makefile, you do not need to list the dependencies of your dependencies. For example, for europe_fit.png: You only need to list gap_figures.R and gap_reorder.RDS as dependencies since those are the only files directly needed to generate that figure. The other figures do not get called by gap_figures.R, and gapminder.tsv is called indirectly through gap_reorder.RDS so it doesn’t need to be listed as well
• Good job with your exploratory analysis! You showed some pretty good plots and reordered the factor levels of continents by life expectancy. For your statistical analysis, it wasn’t really clear what pop_fit2 and pop_fit_total looked like until I ran the code myself. Please show the relevant data frames and tables in your report!
• Your tasks deviated a little bit from what the assignment asks (generating plots for all continents), however you did a pretty good job with getting make to work which was the main point of this assignment.
• Overall, this was solid work for an assignment. However, it would have been nice to see some more comments and explanations in your markdown file. Good work getting your Makefile to run properly, although just be careful about which dependencies are needed for each part. Good job!

Note: your mark (check minus, check, check plus) will be distributed later.