cheusov / dictd

Client/server software, human language dictionary databases, and tools supporting the DICT protocol (RFC 2229)
71 stars 10 forks source link

Double newlines in log_error / log_info #8

Open Jamie-Landeg-Jones opened 4 years ago

Jamie-Landeg-Jones commented 4 years ago

Hi. I've hacked modified libmaa maa/log.c up until now, but the latest update reminded me that I hadn't actually reported the issue. Oops. Sorry!

Basically, dictd terminates all strings in it's log_error / log_info calls with "\n".

The log_base_va function that is ultimately called in libmaa maa/log.c also terminates the received line with "\n", resulting in all logfile messages having an extra blank line after them.

I'm posting here, because I assume the format in libmaa is correct, but if you'd prefer to alter libmaa rather than dictd, that's obviously your call!

cheers, Jamie