search

chevah / compat

Chevah OS Compatibility Layer
Other
4 stars 1 forks source link

[#5509] Allow cryptography 3.2 with OpenSSL 1.0.2. #103

Closed dumol closed 4 years ago

dumol commented 4 years ago

Scope

Allow cryptography 3.2 on platforms with OpenSSL 1.0.2.

This is an issue on python-package, where the necessary CRYPTOGRAPHY_ALLOW_OPENSSL_102 env var is set for normal compat tests, but not propagated for elevated tests run through sudo.

Changes

Export the relevant env var unconditionally.

Drive-by change:

How to try and test the changes

reviewers: @adiroiban

Please review changes.

Check that compat tests ran from this branch are green with cryptography 3.2.1 on Amazon 2 and CentOS 7 (check the patch diff for the branch toggle):

https://chevah.com/buildbot/builders/python-package-amzn-2/builds/95 https://chevah.com/buildbot/builders/python-package-rhel-7/builds/166

codecov[bot] commented 4 years ago

Codecov Report

Merging #103 (402aa91) into master (10ed7a0) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #103   +/-   ##
=======================================
  Coverage   89.44%   89.44%           
=======================================
  Files          61       61           
  Lines        7913     7914    +1     
  Branches      652      652           
=======================================
+ Hits         7078     7079    +1     
  Misses        646      646           
  Partials      189      189
Impacted Files Coverage Δ
chevah/compat/__init__.py 100.00% <100.00%> (ø)
chevah/compat/tests/normal/test_filesystem.py 98.83% <100.00%> (ø)
chevah/compat/testing/testcase.py 78.32% <0.00%> (-0.19%) :arrow_down:
chevah/compat/capabilities.py 71.05% <0.00%> (+2.63%) :arrow_up:
dumol commented 4 years ago

needs-review

adiroiban commented 4 years ago

I have released 0.58.3 to Chevah PyPI server.

adiroiban commented 4 years ago

I have merged it since it was released. Thanks!

dumol commented 4 years ago

I have released 0.58.3 to Chevah PyPI server.

Thanks! I was waiting for the results of compat tests for all python-package slaves yesterday evening.

For the record, all current python-package slaves have passed the compat tests in this branch: https://chevah.com/buildbot/builders/python-package-group-all/builds/39.

trigger triggered python-package-alpine-312 python-package-amzn-2 python-package-obsd python-package-rhel-7 python-package-rhel-8 python-package-ubuntu-1804 python-package-ubuntu-2004 python-package-win-2016 python-package-win-2019 python-package-aix-71-dev python-package-macos-1013 python-package-rhel-5 python-package-aix-53 python-package-fbsd-12 python-package-hpux python-package-sol-10 python-package-sol-10-sparc python-package-sol-112 python-package-sol-112-sparc python-package-sol-11 python-package-ubuntu-1604-arm64 ( 2 hrs, 19 mins, 24 secs )
- no logs -
python-package-hpux #52 SUCCESS
python-package-sol-10 #87 SUCCESS
python-package-aix-53 #58 SUCCESS
python-package-sol-11 #80 SUCCESS
python-package-amzn-2 #98 SUCCESS
python-package-fbsd-12 #11 SUCCESS
python-package-aix-71-dev #79 SUCCESS
python-package-rhel-7 #169 SUCCESS
python-package-sol-112-sparc #22 SUCCESS
python-package-ubuntu-1804 #153 SUCCESS
python-package-ubuntu-1604-arm64 #61 SUCCESS
python-package-sol-10-sparc #23 SUCCESS
python-package-obsd #151 SUCCESS
python-package-ubuntu-2004 #64 SUCCESS
python-package-alpine-312 #31 SUCCESS
python-package-rhel-8 #93 SUCCESS
python-package-macos-1013 #139 SUCCESS
python-package-win-2019 #262 SUCCESS
python-package-sol-112 #24 SUCCESS
python-package-win-2016 #89 SUCCESS
python-package-rhel-5 #12 SUCCESS