Update for Twisted 20.3.0

[adiroiban]

Scope

This updates the compat testing helpers to work with latest Twisted that support Python 2.7.

We were using a very old Twisted version which was a mix of 12.1 and 15.1

With this change, any future upgrade to Twisted should not require and update to compat.

Changes

Update the test case.

Move callCleanup code fix from chevah/server

As a drive by, move the static checks to GitHub Actions. I have also removed the custom skip-ci code as GHA has native support now. I have also update the brink deps... just in case.

How to try and test the changes

reviewers: @danuker

FYI.

This will be used in a PR in chevah/server where will implement Twisted update.

[codecov[bot]]

Codecov Report

Merging #110 (e3ac2fd) into master (c9b0980) will decrease coverage by 0.20%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #110      +/-   ##
==========================================
- Coverage   88.77%   88.56%   -0.21%     
==========================================
  Files          58       58              
  Lines        7829     7839      +10     
  Branches      652      652              
==========================================
- Hits         6950     6943       -7     
- Misses        677      693      +16     
- Partials      202      203       +1     

Impacted Files	Coverage Δ
chevah/compat/testing/testcase.py	79.20% <100.00%> (+0.69%)	:arrow_up:
...hevah/compat/tests/normal/testing/test_testcase.py	100.00% <100.00%> (ø)
chevah/compat/tests/elevated/__init__.py	61.90% <0.00%> (-19.05%)	:arrow_down:
chevah/compat/unix_capabilities.py	88.57% <0.00%> (-5.72%)	:arrow_down:
chevah/compat/capabilities.py	57.89% <0.00%> (-5.27%)	:arrow_down:
chevah/compat/testing/nose_test_timer.py	94.38% <0.00%> (-3.38%)	:arrow_down:
chevah/compat/testing/mockup.py	82.90% <0.00%> (-1.56%)	:arrow_down:
chevah/compat/tests/normal/test_capabilities.py	78.37% <0.00%> (-1.09%)	:arrow_down:
chevah/compat/unix_users.py	75.56% <0.00%> (-0.76%)	:arrow_down:
... and 2 more

[adiroiban]

I think that this is ready for a first needs-review

I still need to fix static-checks now that they are moved to GitHub ...and fix AIX 7.1... as we use the new VM

[dumol]

As I'm trying to get rid of Alpine Linux VMs, have added a workflow to test it under Docker.

As I have found more Buildbot OS'es were being required from Buildbot (but missing because they were recently removed), I've added them back through Docker: Amazon Linux 2, CentOS 7/8.

Also re-added Windows Server 2016 through GHA.

While at it, I've also added Amazon Linux 2018.03 and CentOS 8.2 through Docker.

Some tests fail consistently on CentOS 8.x (and they are not the same on 8,2 and latest 8).

Some small adjustments for brink.sh for Docker containers and better outputs on distros where the generic runtime is used.

[adiroiban]

Thanks @dumol for the update. This is a great start.

Maybe some tests are failing due to umask differences.

But I think that the remaining can be fixed as part of the py3 migration.