search

chevah / compat

Chevah OS Compatibility Layer
Other
4 stars 1 forks source link

Fix docker tests. #116

Closed adiroiban closed 3 years ago

adiroiban commented 3 years ago

Scope

This is a small PR to fix the docker tests on centos.

Changes

set umask like chevah/server

use /usr/bin/curl for a reference binary.

The bin/cp was a small file on centos and could be confused with a symlink.

I have also updated the compat brink.sh and python version.

On alpine, PAM usage is crashing big times, with segfault. For now, I have just disable it as I don't plan to use PAM on alpine.

How to try and test the changes

reviewers: @dumol

Check that changes make sense.

Scope

This is a small PR to fix the docker tests on centos and alpine.

The centos issue was minor. The alpine is big as trying to call PAM will segfault. For now we just skip PAM on Alpine.

codecov[bot] commented 3 years ago

Codecov Report

Merging #116 (bee081e) into master (db67cbf) will decrease coverage by 0.06%. The diff coverage is 44.44%.

@@            Coverage Diff             @@
##           master     #116      +/-   ##
==========================================
- Coverage   87.69%   87.62%   -0.07%     
==========================================
  Files          58       58              
  Lines        7941     7946       +5     
  Branches      653      655       +2     
==========================================
- Hits         6964     6963       -1     
- Misses        765      768       +3     
- Partials      212      215       +3
Impacted Files Coverage Δ
chevah/compat/tests/elevated/test_system_users.py 89.41% <ø> (+0.69%) :arrow_up:
chevah/compat/tests/normal/test_capabilities.py 47.05% <0.00%> (-0.51%) :arrow_down:
chevah/compat/unix_capabilities.py 82.50% <40.00%> (-6.08%) :arrow_down:
chevah/compat/tests/normal/test_filesystem.py 97.77% <100.00%> (ø)
chevah/compat/testing/testcase.py 79.93% <0.00%> (-0.52%) :arrow_down:
adiroiban commented 3 years ago

@dumol please take a look. thanks

this is a back to work present :)

needs-review

dumol commented 3 years ago

Thanks, looks good!

win-2012 testing still missing, but you can make the repo private and test windows through our VMs, I guess…

changes-approved

adiroiban commented 3 years ago

Thanks. I am merging this. I think win 2012 should be fine... as is not much different than 2016 .... waiting to see if Win Server 2022 will be a big change.