Closed chevah-robot closed 3 years ago
Comment by pqm at 2021-06-08 16:15:25Z.
danuker requested the review of this ticket.
needs-review
Comment by pqm at 2021-06-08 16:36:52Z.
adi needs-changes to this ticket.
Looks good. Thanks.
I left a comment with the release process for releasing a library.
The idea is that the main branch should always have a .dev0
version.
The release should be done based on a tag that has a final version.
Comment by pqm at 2021-06-08 19:22:38Z.
danuker requested the review of this ticket.
as with twine you can have everything in one command line.
Doesn't look like twine supports building the wheel; I used system/user pip for the shorter and more memorable command; I checked the wheels and there is minimal difference (AUTHORS and LICENSE files included as License-File:
fields). Tell me what you think.
Other than that, this should be ready.
needs-review
Comment by pqm at 2021-06-08 22:26:07Z.
adi changes-approved. No more reviewers. Ready to merge.
All good. Please create and push the tag and then merge this (with updated dev0 version)
Thanks!
Comment by pqm at 2021-06-09 07:10:22Z.
danuker requested the review of this ticket.
Had to change the pre-release convention. Please check it out. needs-review
Comment by pqm at 2021-06-09 07:23:09Z.
adi changes-approved. No more reviewers. Ready to merge.
All good. Thanks
Comment by pqm at 2021-06-09 07:33:49Z.
Branch landed on master. Now go and update your master branch.
T5656 task was created by danuker on 2021-06-08 15:49:55Z. Last changed on 2021-06-09 07:33:49Z. PR at https://github.com/chevah/brink/pull/133.
Release the Python 3 version of Brink, to be used in Pythia.