search

chevah / compat

Chevah OS Compatibility Layer
Other
4 stars 1 forks source link

Remove brink dependency on compat #135

Closed chevah-robot closed 3 years ago

chevah-robot commented 3 years ago

T5639 task was created by danuker on 2021-05-23 16:08:43Z. Last changed on 2021-06-01 09:27:18Z. PR at https://github.com/chevah/brink/pull/129.

Part of #134 : make brink executable without compat.

chevah-robot commented 3 years ago

Comment by pqm at 2021-05-31 12:10:45Z.

adi changes-approved.

Thanks for the update. It looks good.

The big blocker is making sure we add a "brink" marker to the new temporary files that are created in the OS tmp root folder.

With chevah-compat test case, each test run would have a sub-folder inside the OS temporary root.

chevah-robot commented 3 years ago

Comment by pqm at 2021-05-31 13:55:34Z.

danuker requested the review of this ticket.

needs-review

chevah-robot commented 3 years ago

Comment by pqm at 2021-06-01 08:42:19Z.

adi changes-approved. No more reviewers. Ready to merge.

Thanks. Looking forward to the py3 migration PR :)

chevah-robot commented 3 years ago

Comment by pqm at 2021-06-01 09:27:18Z.

Branch landed on master. Now go and update your master branch.