search

chevah / compat

Chevah OS Compatibility Layer
Other
4 stars 1 forks source link

Build 32bit binaries on Solaris. #242

Closed chevah-robot closed 7 years ago

chevah-robot commented 7 years ago

T4244 task was created by dumol on 2017-07-20 11:01:51Z. Last changed on 2017-08-01 09:49:18Z. PR at https://github.com/chevah/python-package/pull/84.

We have at least a client with issues regarding RAM usage on Solaris 10.

Let's see if 32binaries on Solaris would alleviate the issue. On the other commercial UNIX'es (AIX and HP-UX) we only have 32bit binaries.

chevah-robot commented 7 years ago

Comment by pqm at 2017-07-21 13:23:37Z.

dumol requested the review of this ticket.

needs-review

chevah-robot commented 7 years ago

Comment by pqm at 2017-07-24 09:19:54Z.

adi needs-changes to this ticket.

I think that paver.sh should still detect the CPU as it is.. 64bit.

Also, we should keep the python binary name as SPARC64 even if we build 32bit

The name is about the targeted CPU, and we target the modern sparc 64bit cpu.

we should build 32 only on SPARC

thanks!

needs-changes

chevah-robot commented 7 years ago

Comment by pqm at 2017-07-24 11:42:12Z.

dumol requested the review of this ticket.

paver.sh detects the CPU correctly as sparcv9. But we have that sub-routine for normalizing arch names and forcing 32bit builds on some OS'es, which is a bit of kludge, but a necessary one. I tried to simplify it in this PR.

Anyway, I'm fine with forcing 32bit build on SPARC only, but I'm strongly against using sparc64 for 32bit builds on SPARC because:

  1. We use the same convention for forcing 32bit builds on AIX. CPU is detected as ppc64 and we force 32bit builds by using ppc.
  2. There are lots of place in chevah_build where we check for 64bit options by testing if $ARCH ends with 64.

needs-review

chevah-robot commented 7 years ago

Comment by pqm at 2017-07-24 13:17:52Z.

adi changes-approved. No more reviewers. Ready to merge.

make sense. thanks!

chevah-robot commented 7 years ago

Comment by pqm at 2017-07-24 13:58:50Z.

dumol requested the review of this ticket.

paver.sh detects the CPU correctly as sparcv9. But we have that sub-routine for normalizing arch names and forcing 32bit builds on some OS'es, which is a bit of kludge, but a necessary one. I tried to simplify it in this PR.

Anyway, I'm fine with forcing 32bit builds on SPARC only in Solaris, but I'm strongly against using sparc64 for 32bit builds on SPARC because:

  1. We use the same convention for forcing 32bit builds on AIX. CPU is detected as ppc64 and we force 32bit builds by using ppc.
  2. There are lots of place in chevah_build where we check for 64bit options by testing if $ARCH ends with 64.

needs-review

chevah-robot commented 7 years ago

Comment by pqm at 2017-07-24 14:00:22Z.

Branch landed on master. Now go and update your master branch.