chevah / compat

Chevah OS Compatibility Layer
Other
4 stars 1 forks source link

[#685] Add support for long file paths. #687

Closed adiroiban closed 1 year ago

adiroiban commented 1 year ago

Scope

Fixes #685

This tries to fix filesystem to handle long file paths.

Changes

Enable CI with temp on a long path and fix the implementation to get the tests green.

How to try and test the changes

reviewers: @danuker

just a code review her.

We will do manual tests in chevh/server

codecov[bot] commented 1 year ago

Codecov Report

Merging #687 (8ac5a17) into master (47cd37a) will decrease coverage by 0.06%. The diff coverage is n/a.

:exclamation: Current head 8ac5a17 differs from pull request most recent head 0de662f. Consider uploading reports for the commit 0de662f to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #687 +/- ## ========================================== - Coverage 88.22% 88.16% -0.06% ========================================== Files 58 58 Lines 8178 8205 +27 Branches 669 676 +7 ========================================== + Hits 7215 7234 +19 - Misses 753 757 +4 - Partials 210 214 +4 ``` [see 7 files with indirect coverage changes](https://app.codecov.io/gh/chevah/compat/pull/687/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=chevah) | Components | Coverage Δ | | |---|---|---| | tests | `∅ <ø> (∅)` | |
adiroiban commented 1 year ago

For now this is only py2 code.

Once all is ok, the plan is to merge this into master and then merge the changes into #676

needs-review

adiroiban commented 1 year ago

Many thanks @danuker for the review.

I am working in parallel to get the chevah/server tests working and I might need to do minor changes before the final merge.

but I think that 99% is ok.

adiroiban commented 1 year ago

I am going to merge this as the chevah/server tests look green.

I will follow with the patch for py3 version.