chevah / compat

Chevah OS Compatibility Layer
Other
4 stars 1 forks source link

[#203] Fix handling of long Windows Share UNC path #697

Closed adiroiban closed 4 months ago

adiroiban commented 4 months ago

Scope

Fixes #203

There is wrong path resolution for Windows Share long paths.

It should be \\?\UNC\server-name ... instead of \\?\server-name

Changes

Update implementation and tests

How to try and test the changes

reviewers: @dumol

How the changes can be tested and verified by team members. How to run manual tests.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.09%. Comparing base (d4a3dfc) to head (83b4235). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #697 +/- ## ========================================== - Coverage 79.47% 79.09% -0.39% ========================================== Files 52 51 -1 Lines 7800 7810 +10 Branches 1275 1174 -101 ========================================== - Hits 6199 6177 -22 - Misses 1333 1366 +33 + Partials 268 267 -1 ``` [see 45 files with indirect coverage changes](https://app.codecov.io/gh/chevah/compat/pull/697/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=chevah) | [Components](https://app.codecov.io/gh/chevah/compat/pull/697/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=chevah) | Coverage Δ | | |---|---|---| | [tests](https://app.codecov.io/gh/chevah/compat/pull/697/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=chevah) | `∅ <ø> (∅)` | |
adiroiban commented 4 months ago

@dumol more if a FYI. I have merged all the tests in a single workflow, to make it easier to view the status.

I am merging this PR without a review. You can check this PR once you are back.