search

chevah / compat

Chevah OS Compatibility Layer
Other
4 stars 1 forks source link

[#699] Python 3.12 update. #700

Closed dumol closed 1 month ago

dumol commented 1 month ago

Scope

Fixes #699

Updates for Python 3.12.

Changes

Use pynose and importlib.utils instead of nose and imp.

Drive-by changes:

How to try and test the changes

reviewers: @adiroiban

Have only tried to have things green and to follow #693.

Do check if the diff looks alright.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.05%. Comparing base (0ab5293) to head (a84aae6). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #700 +/- ## ========================================== - Coverage 79.05% 79.05% -0.01% ========================================== Files 47 47 Lines 7739 7738 -1 Branches 1172 1151 -21 ========================================== - Hits 6118 6117 -1 Misses 1355 1355 Partials 266 266 ``` [see 1 file with indirect coverage changes](https://app.codecov.io/gh/chevah/compat/pull/700/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=chevah) | [Components](https://app.codecov.io/gh/chevah/compat/pull/700/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=chevah) | Coverage Δ | | |---|---|---| | [tests](https://app.codecov.io/gh/chevah/compat/pull/700/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=chevah) | `∅ <ø> (∅)` | |
dumol commented 1 month ago

There's one more thing needed before a new compat release: production packages of Pythia. This PR has been using testing packages generated in https://github.com/chevah/pythia/pull/58, which is not yet merged.

adiroiban commented 1 month ago

Yes... for chevah/compat is not that critical..

I am a bit worried about the new libnsl dependency ... but I see that the code works on OracleLinux 8

I think that we should update the GitHub Actions on Pythia to run some minimal tests via Docker on multiple centos versions ... just to make sure we got our dynamic libraries right

dumol commented 1 month ago

I think that we should update the GitHub Actions on Pythia to run some minimal tests via Docker on multiple centos versions ... just to make sure we got our dynamic libraries right

Tracked at https://github.com/chevah/pythia/issues/68.