chevah / github-hooks-server

Handling of GitHub hooks for Chevah project
BSD 3-Clause "New" or "Revised" License
1 stars 1 forks source link

For "needs-review" marker ask for a review via the "Reviewers" PR metadata. #44

Open adiroiban opened 2 years ago

adiroiban commented 2 years ago

Right now, when a review is requested the targeted reviewers are "assigned" to that PR.

This is due to legacy reasons, as in the past there was no "reviewers" metadata for the PR.

Now, instead of assigning a PR to the reviewers, the reviewers should be assigned via the dedicated field.

In summary:


Here are the 2 fields.

image


Note that this is only valid for PRs.

For issues, we will continue to have the existing behavior via "Assignees"

danuker commented 2 years ago

testing.

needs-review

adiroiban commented 2 years ago

For an issue, we will still use the "Asigneed" field, as there is no "reviewers" metadata for an issue.