chevah / github-hooks-server

Handling of GitHub hooks for Chevah project
BSD 3-Clause "New" or "Revised" License
1 stars 1 forks source link

Update deps: part 2 #69

Closed danuker closed 4 months ago

danuker commented 4 months ago

Revenge of #67

grpcio was obsolete because azure-functions-worker was obsolete. Trying the official MS guide, the requirements only include azure-functions, and nothing else.

See if the deployment works without azure-functions-worker.

adiroiban commented 4 months ago

We can just remove it from here

https://github.com/chevah/github-hooks-server/blob/3e956426ba850371fd0c2256cadedec108bf9a3d/requirements.txt#L217


We might want to have 2 requirement files.

The high-level requirements.txt with only the direct deps, and without hash.

Or just use what we have now

https://github.com/chevah/github-hooks-server/blob/3e956426ba850371fd0c2256cadedec108bf9a3d/setup.py#L46-L49


And a Pipfile.lock with the full list of deps and hash values

or use a command to automatically regenarate the requirments.txt based on setup.py

danuker commented 4 months ago

requirements.txt was created automatically by poetry-plugin-export from the [tool.poetry.dependencies] section of pyproject.toml.

I did this to avoid having to manually handle tons of dependency hashes which Azure Functions requires.

I also use requirements.txt as a witness that the project worked with those versions (so, the same role as Pipfile.lock). Poetry also creates poetry.lock but it would be redundant to commit it to the repo.


It seems we don't need azure-functions-worker, grpcio, protobuf, nor Node anymore. We needed Node for Serverless, but it has been replaced by the trivial build-package.sh.