search

chewiebug / GCViewer

Fork of tagtraum industries' GCViewer. Tagtraum stopped development in 2008, I aim to improve support for Sun's / Oracle's java 1.6+ garbage collector logs (including G1 collector)
https://github.com/chewiebug/GCViewer/wiki
Other
4.44k stars 974 forks source link

Lack of application stopped time in unified java logging #205

Open kcrimson opened 5 years ago

kcrimson commented 5 years ago

As I understand as of now, GCviewer doesn't parse log entries with "safepoint" tag. Which means APPLICATION_STOPPED_TIME events are not parsed and not available in GcModel. I think for consistency with other formats, we should support it. I can work on it if you are ok with this change. .

chewiebug commented 5 years ago

Hi Jaroslav,

You are right, GCViewer does not support APPLICATION_STOPPED_TIME for the java unified logging format, at the moment.

If you would like to give adding support for APPLICATION_STOPPED_TIME a try, you are very welcome! You will probably have to update DataReaderUnifiedJvmLogging. An event type already exists in AbstractGcEvent.

If you need more hints, please just tell me.

Best regards, Jörg

kcrimson commented 5 years ago

Ok, so I will take this one, I have first attempt running, will open PR soon

chewiebug commented 5 years ago

Cool!

kcrimson commented 5 years ago

ok, here is PR, https://github.com/chewiebug/GCViewer/pull/208/files, let me know, I changed a bit parsing logic, I first extract decorators and the try to parse gc event or vm operation.

kcrimson commented 5 years ago

@chewiebug I see red on my PR from Better Code Hub, but I am not able to see results, how can I get access to it?