Open kcrimson opened 5 years ago
Hi Jaroslav,
You are right, GCViewer does not support APPLICATION_STOPPED_TIME for the java unified logging format, at the moment.
If you would like to give adding support for APPLICATION_STOPPED_TIME a try, you are very welcome! You will probably have to update DataReaderUnifiedJvmLogging. An event type already exists in AbstractGcEvent.
If you need more hints, please just tell me.
Best regards, Jörg
Ok, so I will take this one, I have first attempt running, will open PR soon
Cool!
ok, here is PR, https://github.com/chewiebug/GCViewer/pull/208/files, let me know, I changed a bit parsing logic, I first extract decorators and the try to parse gc event or vm operation.
@chewiebug I see red on my PR from Better Code Hub, but I am not able to see results, how can I get access to it?
As I understand as of now, GCviewer doesn't parse log entries with "safepoint" tag. Which means APPLICATION_STOPPED_TIME events are not parsed and not available in GcModel. I think for consistency with other formats, we should support it. I can work on it if you are ok with this change. .