search

chewiebug / GCViewer

Fork of tagtraum industries' GCViewer. Tagtraum stopped development in 2008, I aim to improve support for Sun's / Oracle's java 1.6+ garbage collector logs (including G1 collector)
https://github.com/chewiebug/GCViewer/wiki
Other
4.47k stars 979 forks source link

Fix quitting on macOS #248

Closed jkaving closed 4 years ago

jkaving commented 4 years ago

The QuitHandler that proxies our Exit action needs to call the performQuit() method on the QuitResponse that it receives. See the Javadoc for com.apple.eawt.QuitHandler.handleQuitRequestWith() which says:

  /**
   * Invoked when the application is asked to quit.
   *
   * Implementors must call either {@link QuitResponse#cancelQuit()}, {@link QuitResponse#performQuit()}, or ensure the application terminates.
   * The process (or log-out) requesting this app to quit will be blocked until the {@link QuitResponse} is handled.
   ...

Fixes #247

chewiebug commented 4 years ago

Thank you very much for your contribution!