search

chewing / chewing-editor

Cross platform chewing user phrase editor
https://chewing.im/
GNU General Public License v2.0
31 stars 52 forks source link

Hide Close from File menu on OS X #129

Closed david50407 closed 8 years ago

david50407 commented 8 years ago

As screenshot below, on OS X, there will be a built-in Quit item in the main menu. For matching OS X users' habit and avoiding ambiguous , maybe we can hide Close from File menu?

2016-03-25 10 53 30

david50407 commented 8 years ago

http://doc.qt.io/qt-5/osx-issues.html#menu-bar

Additionally, users expect certain conventions to be respected, for example the application menu should contain About, Preferences, Quit, and so on.

And say as the document in Qt, should we move About Chewing Editor into the main menu on OS X?

Chocobo1 commented 8 years ago

For matching OS X users' habit and avoiding ambiguous , maybe we can hide Close from File menu? And say as the document in Qt, should we move About Chewing Editor into the main menu?

can you elaborate more? don't have a mac to see what you're saying.

david50407 commented 8 years ago

On OS X, there will be at least one main menu called Application Menu, it ofter contains highly related actions to the application, like about, preference/setting, quit.

2016-03-25 12 55 16

And the File menu is like other platforms but moved out these items showed in Application menu.

2016-03-25 12 57 23

It also moves about from Help to Application menu.

2016-03-25 12 58 42

Chocobo1 commented 8 years ago

I understand now (but a bit vaguely...), seems easy to fix. Patches welcome, if the patch doesn't clog up the code readability.

And for UI changes, do provide before & after screenshots.

UPDATE: the changes should be osx only, other platform should remain the same.