search

chewing / chewing-editor

Cross platform chewing user phrase editor
https://chewing.im/
GNU General Public License v2.0
31 stars 52 forks source link

Fix .gitignore patterns #130

Closed Chocobo1 closed 8 years ago

Chocobo1 commented 8 years ago

I usually build in a dir at <project_root>/build, the current .gitignore doesn't work properly for me.

personal complains: why so obsessed with /? git applies the patterns to all dirs...

jserv commented 8 years ago

Note the /* - without the slash, the wildcard would also exclude everything within foo/bar. I expect to follow the existing patterns.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 94.382% when pulling ecdf2646921505314854a7404aef85572a0b00ae on Chocobo1:ignore into f7f3123b4c3497649792cbc78318d504f540aa90 on chewing:master.

Chocobo1 commented 8 years ago

Note the /* - without the slash

Probably I updated or removed it, now that pattern does not exist.

I expect to follow the existing patterns.

If you mean to keep the existing patterns: As I said, that won't work if someone is doing a out-of-source build, which is a big & convenience feature for using cmake.

jserv commented 8 years ago

@Chocobo1 : We can explicitly mark the restrictions for out-of-source build. It is quite crucial, and we should discuss on chewing-devel@ mailing-list.

czchen commented 8 years ago

Good for me.