search

chewing / chewing-editor

Cross platform chewing user phrase editor
https://chewing.im/
GNU General Public License v2.0
31 stars 52 forks source link

Make menu more natively on Mac OS X #132

Closed david50407 closed 8 years ago

david50407 commented 8 years ago

This will close #129.

Before:

2016-03-25 10 53 30 2016-03-25 14 44 59 2016-03-25 14 45 03

After:

2016-03-25 14 40 51 2016-03-25 14 40 59

ref: http://www.slideshare.net/qtbynokia/how-to-make-your-qt-app-look-native

Notice that chewing-editor only can be changed in other way, I'll send a patch later.

jserv commented 8 years ago

Do the property changes have impacts over Qt on GNU/Linux and Windows?

Chocobo1 commented 8 years ago

@david50407 Nice find!

also here's the Qt doc: https://doc.qt.io/qt-5/qaction.html#MenuRole-enum

don't forget to append Closes #129. to commit log.

david50407 commented 8 years ago

@Chocobo1 if there is "Close #129" inside the PR's description, when it merged, it'll close the issue, too

Chocobo1 commented 8 years ago

@Chocobo1 if there is "Close #129" inside the PR's description, when it merged, it'll close the issue, too

Yes, but you won't be able to trace back to the issue by just looking at the git log.

UPDATE: you also get a nice link (on Github) which links back directly to the issue.

david50407 commented 8 years ago

@Chocobo1 got it. updated the commit. @jserv no it won't change anything on other platform..

coveralls commented 8 years ago

Coverage Status

Changes Unknown when pulling f3ebc6959009b4650026c38505b452a32103e924 on david50407:feature/menu_on_osx into \ on chewing:master**.

Chocobo1 commented 8 years ago

Thanks for the patch.