search

chewing / chewing-editor

Cross platform chewing user phrase editor
https://chewing.im/
GNU General Public License v2.0
31 stars 52 forks source link

Add Confirm window before deleting #158

Closed YWJamesLin closed 8 years ago

YWJamesLin commented 8 years ago

I think this is important, then I make a simple dialog. Please check my code. Fix Issue #155

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 94.382% when pulling be653437332dda3b87ed6282a9963975ef2cb8b6 on YWJamesLin:master into 3fe8357c70e1632c1418e83f93fed7d6d4f3b799 on chewing:master.

david50407 commented 8 years ago

I think UNDO is enough, it seems have be discussed on google group (link) and the issue is opened: https://github.com/chewing/chewing-editor/issues/133

david50407 commented 8 years ago

BTW, rebase your commit first, the merge commit shouldn't be here.

jserv commented 8 years ago

@YWJamesLin : please defer to the @david50407 's suggestion to perform rebase.

YWJamesLin commented 8 years ago

Since the UNDO Function is to be implemented, this feature maybe is useless, and I directly merge my commit to master branch, I have deleted the old folked branch. Should I open another Pull Request of this feature with rebase ?

kidwm commented 8 years ago

@YWJamesLin just create another PR.