search

chewing / chewing-editor

Cross platform chewing user phrase editor
https://chewing.im/
GNU General Public License v2.0
31 stars 52 forks source link

Change icon background to transparent #162

Closed redfish-lee closed 8 years ago

redfish-lee commented 8 years ago

Inspired by dialog view of PR #120, I change icon (.svg) background to transparent.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 94.382% when pulling d5bfdf67e3d89417c2256d454f898edb70de2c85 on redfish-lee:master into 3fe8357c70e1632c1418e83f93fed7d6d4f3b799 on chewing:master.

david50407 commented 8 years ago

If you want to change the icon in about dialog I made, you need to change /rc/chewing-editor.ico and this will also be the application icon on Windows.

Chocobo1 commented 8 years ago

what about users who have dark desktop wallpaper?

and users who uses dark theme in their OS UI?

david50407 commented 8 years ago

what about users who have a dark desktop wallpaper?

Agree. We only have black 酷 word for our icon now, maybe it can still have white border around the word, but not a white square behind it?

EDIT: IMO, the icon is toooooooo simple that user may not notice the word on the icon. Maybe white background is the best choice for now. But make a discussion is good. maybe we'll have prettier icon :)

redfish-lee commented 8 years ago

I didn't consider the dark-theme users. Thanks for advice (: