Show application icon on non-Windows

chewing / chewing-editor

Cross platform chewing user phrase editor

https://chewing.im/

GNU General Public License v2.0

31 stars 52 forks source link

Closed david50407 closed 8 years ago

david50407 commented 8 years ago

As title, for now, we only show rc/chewing-editor.ico as application icon on Windows.

Chocobo1 commented 8 years ago

cinnamon DE doesn't show app icon at all so I'm not sure how it works on other DEs (and osx).

screenshot

jserv commented 8 years ago

Is this issue valid for latest chewing-editor since PNG icon is used instead?

david50407 commented 8 years ago

Yes, it's still showing the default icon on Ubuntu.

Chocobo1 commented 8 years ago

@david50407 Please test PR #174.

david50407 commented 8 years ago

@Chocobo1 works on Ubuntu

Chocobo1 commented 8 years ago

@Chocobo1 works on Ubuntu

Thanks for confirming.