chewing / chewing-editor

Cross platform chewing user phrase editor
https://chewing.im/
GNU General Public License v2.0
31 stars 52 forks source link

Make as bundle on Mac OS X #167

Closed david50407 closed 8 years ago

david50407 commented 8 years ago

This will solve #127 when the program build as bundle (.app). And also solve the problem that now will display "Chewing Editor" as application name mentioned in #132. Added localization info files (English and zh_TW) for showing local language file dialog.

As the screenshot below, now will build a .app bundle on Mac OS X. 2016-03-28 10 59 07

And shows icon on dock 2016-03-28 11 01 17

Application name is changed into 新酷音詞庫編輯器 (in zh_TW) or Chewing Editor (in English) 2016-03-28 11 00 57

Localized dialog 2016-03-28 11 03 44 2016-03-28 11 03 55

david50407 commented 8 years ago

This is a BIG change because I added a part for OS X in CMakeList.txt and created localization folders for OS X in rc, but I didn't know if they can put in there or should be another place. @Chocobo1 How do you think?

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 94.382% when pulling 0a4648bb5d471068a5168c24a8840958bead672a on david50407:feature/bundle_on_osx into 4179529596706284a906baa878f95fd18c8a915a on chewing:master.

czchen commented 8 years ago

@david50407 Not a OS X user, but this patch looks good for me. I think you can merge it first, and then change the file location later if necessary.

Chocobo1 commented 8 years ago

but I didn't know if they can put in there or should be another place.

OK for current location.

david50407 commented 8 years ago

Updated and move the APPLE part to cmake/platform_apple.cmake

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 94.382% when pulling 4d696b61dfeabbbb837ac8554583056af4029ddf on david50407:feature/bundle_on_osx into d7227c046c3270bfd8766e05a9c126efb525ff58 on chewing:master.

Chocobo1 commented 8 years ago

OK, rebase and I'll merge it (or you can do it yourself?)

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 94.382% when pulling 4b5da5247d18765aaf750e8c76ea3373a100ea38 on david50407:feature/bundle_on_osx into 1cf0b06c95fe131a899c7051370f03c16662b1a5 on chewing:master.

kidwm commented 8 years ago

@david50407 How do you use Chewing on Mac OS X? SpaceChewing or OpenVanilla?