search

chewing / chewing-editor

Cross platform chewing user phrase editor
https://chewing.im/
GNU General Public License v2.0
31 stars 52 forks source link

Solve character ambiguity and refresh() #169

Closed robert501128 closed 8 years ago

robert501128 commented 8 years ago

Automatically change the character from "一" to "ㄧ" Add refresh() function in the add function to reduce the problem of wrong bopomofo

robert501128 commented 8 years ago

here is what I have changed issue＃106

david50407 commented 8 years ago

How about also replace 丫 to ㄚ

robert501128 commented 8 years ago

I have changed the file based on the suggestion.

coveralls commented 8 years ago

Coverage Status

Changes Unknown when pulling 50fef5446be3314c6d2d86ca2baf6f9b9f28365d on robert501128:master into \ on chewing:master**.

Chocobo1 commented 8 years ago

I think this is almost ready :+1: you should squash all your commits into 1 commit.

jserv commented 8 years ago

Improve the GIT commit messages about checkBopomofo as well.

coveralls commented 8 years ago

Coverage Status

Changes Unknown when pulling fed35760c7be484478caacbeae0c506b4f507e68 on robert501128:master into \ on chewing:master**.

jserv commented 8 years ago

@robert501128 : per @Chocobo1's suggestion, please use git rebase -i to squash your commits. Reference: https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 94.382% when pulling c4682b75041fd2d10c7dc9c192f03463ec40f769 on robert501128:master into 5c029562e566371bbb7eb647c444f3c54c25dc86 on chewing:master.

robert501128 commented 8 years ago

Ok, I'm just new in github so I was figuring out how to squash commits just now. I've squashed all commits and add the comments to explain my function.

jserv commented 8 years ago

@robert501128 : The GIT commit messages do not look effective. Please refer to the article How to Write a Git Commit Message.

robert501128 commented 8 years ago

Thanks, learn a lot.

Chocobo1 commented 8 years ago

I've squashed all commits and add the comments to explain my function.

Just in case you haven't figure it out yet:

add the comments to explain my function.

The comments you added is recorded at github website, it won't transfer along with the git repository, so you need to either move the comments into the code, or move the comments to git log (when you do amending commits).

david50407 commented 7 years ago

Oops this PR doesn't replace chinese word 一 into bopomofo ㄧ correctly, this mis-replaced the bopomofo ㄧ into bopomofo ㄧ (the same one), and also 丫 is not going into ㄚ, I'm going to create another PR to fix it. But we still need a good solution to #108.

cc @jserv