Closed YWJamesLin closed 8 years ago
I think you should squash these two commits into one.
Never say "The same as title".
Don't know why you closed this PR.
If you're willing to improve/refactor it: I suggest you use QMessageBox
instead of creating a new kind of message box.
Since I don't know how to edit the pull request. I know how to squash commit, but I don't know how to edit PR to use another commit... I will improve that and open another PR...
For a start, you just write some code and do some changes and then git commit
as usual, then when you're satisfy with it, start git rebase -i
to squash the commits.
Then you git push -f
to push your changes to github and leave a message for us to start another round of review.
I know how to squash commit, but I don't know how to edit PR to use another commit...
When you add new commit to your feature-deleteConfirmWindow
branch and then git push
, it will also update this PR.
In short, branch feature-deleteConfirmWindow
is linked with this PR (ONLY when it's open!).
@Chocobo1 Thank you!
I've fixed these problem!
I'll try to improve this feature with QMessageBox
.
@jserv @david50407 I've edited the content of this PR, and squashed the two commits with indentation fixing. By the way, should I provide a snapshot of this feature?
@YWJamesLin : Can you improve the GIT commit messages to mention what the new feature is?
Also, it is required to rebase. Please do check the documentation about git rebase
.
To all: Now I have refactored the code. @jserv Since I refactor the code, I don't modify the remove() method. I think I just totally do one thing (just add comfirm window) and I may need only one commit. If you think this is not a good choice, please give some advice. @Chocobo1 I have refactor this by using QMessageBox instead of QDialog, please check again.
OK for me (and give other maintainers some time to review it).
@YWJamesLin : You can append the issue number associated with this change, and GiHub will automatically close that issue after your contribution is merged. Use git commit --amend
to specify.
The subject should exclude issue number. So, you can rewrite GIT commit messages as following:
add confirmation window while deleting user-phrase
Close #155
I think this is important, then I make a simple dialog. Please check my code.
Known Issue of this PR:
Add icon in this window