Closed jeffreyhc closed 8 years ago
IMO, showing the reason or some tips is better, eg. "Please enter correct bopomofo and try again" or "Please enter the bopomofo for each words"
@david50407 : I update the message.
@jeffreyhc : Crop your screenshot to focus on what you would like to present.
@jserv : I update the picture
When user add phrase failed, (the terminal shows the failed message)
there is a notification to notify user.
@jeffreyhc I meant, you can reorder the windows to be more compact as the tiling presentation.
@jserv : Like this?
@jeffreyhc much better now. You can trim the white area off.
@jserv Is this ok?
@jeffreyhc Pretty good to me. Thanks. Please read this article Accessible Design for Users With Disabilities. We should always prepare the content to the disabled as friendly as possible.
@jeffreyhc Wrap the Git commit message body at 72 characters according to How to Write a Git Commit Message.
@jserv : I remember I should wrap the body at 72 characters, I split the text to two lines because I thought they might exceeded the limit. However, I review the section of How to Write a Git Commit Message and I found I have at most the space of 80 characters.
@jeffreyhc : Thanks for your contribution!
Close #160
When user add phrase fail, there will be a notification tell user the movement is failed:
(The phrase still add in editor because of the auto-learning function in libchewing)
Does the notification need to show the content of the phrase add failed?