chewing / chewing-editor

Cross platform chewing user phrase editor
https://chewing.im/
GNU General Public License v2.0
31 stars 52 forks source link

Notify user when add phrase failed #177

Closed jeffreyhc closed 8 years ago

jeffreyhc commented 8 years ago

Close #160

When user add phrase fail, there will be a notification tell user the movement is failed: default 2 (The phrase still add in editor because of the auto-learning function in libchewing)

Does the notification need to show the content of the phrase add failed?

david50407 commented 8 years ago

IMO, showing the reason or some tips is better, eg. "Please enter correct bopomofo and try again" or "Please enter the bopomofo for each words"

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 94.382% when pulling 1ee7156c43e80764ac823973db37552b3e2b343d on jeffreyhc:new into 5fb676f21948b0a50ee8dffad1eea0e7618226d2 on chewing:master.

jeffreyhc commented 8 years ago

@david50407 : I update the message. default

jserv commented 8 years ago

@jeffreyhc : Crop your screenshot to focus on what you would like to present.

jeffreyhc commented 8 years ago

@jserv : I update the picture default When user add phrase failed, (the terminal shows the failed message) there is a notification to notify user.

jserv commented 8 years ago

@jeffreyhc I meant, you can reorder the windows to be more compact as the tiling presentation.

jeffreyhc commented 8 years ago

@jserv : Like this? 1

jserv commented 8 years ago

@jeffreyhc much better now. You can trim the white area off.

jeffreyhc commented 8 years ago

@jserv Is this ok? 2

jserv commented 8 years ago

@jeffreyhc Pretty good to me. Thanks. Please read this article Accessible Design for Users With Disabilities. We should always prepare the content to the disabled as friendly as possible.

jserv commented 8 years ago

@jeffreyhc Wrap the Git commit message body at 72 characters according to How to Write a Git Commit Message.

jeffreyhc commented 8 years ago

@jserv : I remember I should wrap the body at 72 characters, I split the text to two lines because I thought they might exceeded the limit. However, I review the section of How to Write a Git Commit Message and I found I have at most the space of 80 characters.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 94.382% when pulling 80a009df06f42401a5a1e259a5fc6cc0ae126b92 on jeffreyhc:new into 5fb676f21948b0a50ee8dffad1eea0e7618226d2 on chewing:master.

jserv commented 8 years ago

@jeffreyhc : Thanks for your contribution!