search

chewing / chewing-editor

Cross platform chewing user phrase editor
https://chewing.im/
GNU General Public License v2.0
31 stars 52 forks source link

fix invalid Version value in desktop file. #181

Closed yochenhsieh closed 8 years ago

yochenhsieh commented 8 years ago

Version value should be 1.0, not project version: See https://specifications.freedesktop.org/desktop-entry-spec/latest/ar01s05.html

Note that Version is not a required key and can be removed instead. Close #180.

coveralls commented 8 years ago

Coverage Status

Changes Unknown when pulling ca6b5bf03ee96e96b5a89c3652d002e064a25b99 on yochenhsieh:patch-1 into \ on chewing:master**.

Chocobo1 commented 8 years ago

you should append Close #180. in commit log, so Github can close the issue when merging this PR.

Chocobo1 commented 8 years ago

I mean git commit log.

czchen commented 8 years ago

See https://help.github.com/articles/closing-issues-via-commit-messages/ for how to close issue in GitHub via commit message.

kidwm commented 8 years ago

@Chocobo1 it also works in description of PR.