search

chewing / chewing-editor

Cross platform chewing user phrase editor
https://chewing.im/
GNU General Public License v2.0
30 stars 52 forks source link

Fix remove phrase incorrect behavior [issue #192] #199

Closed hunghw closed 8 years ago

hunghw commented 8 years ago

When I don't have phrase in editor, the remove button should be disabled.

I let the editor check quantity of phrase. If it is zero, I will disable the delete confirmation windows.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 93.714% when pulling 28a244ed30fa23ff1fdd2863506bbc979ed14e73 on hwhung0111:patch-2 into 30b9c303df950bd5f3ebf7cfcd3eb16a8918fc5b on chewing:master.

hunghw commented 8 years ago

@david50407 Thank for your opinion.

david50407 commented 8 years ago

And please squash your commits :smile:

hunghw commented 8 years ago

@david50407 I don't understand what is "squash commits".

david50407 commented 8 years ago

Here's git document for you: https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History#Squashing-Commits

Simply, just want you to merge these two commits into one commit. :+1: