Fix remove phrase incorrect behavior [issue #192]

chewing / chewing-editor

Cross platform chewing user phrase editor

https://chewing.im/

GNU General Public License v2.0

31 stars 52 forks source link

Fix remove phrase incorrect behavior [issue #192] #200

Closed hunghw closed 7 years ago

hunghw commented 8 years ago

I squashed the commits that I mentioned in #199 . This problem come from #192 .

coveralls commented 8 years ago

Coverage remained the same at 93.714% when pulling 175692e6e11d217b8c9b0aa683b8c41a83a61cf9 on hwhung0111:patch-1 into e79a521181997e149cbce63041d692cd985be2fc on chewing:master.

david50407 commented 7 years ago

I think the dectection should be checking if the selection is empty, not only checking if there is no phrases.