search

chewing / chewing-editor

Cross platform chewing user phrase editor
https://chewing.im/
GNU General Public License v2.0
30 stars 52 forks source link

Fixed checkBopomofo() mis-typed by modifying 'ㄧ' into '一' #212

Closed qas612820704 closed 7 years ago

qas612820704 commented 7 years ago

chewing-editor expects when I type

phrase = "你好"
bopomofo = "ㄋ一ˇ ㄏㄠˇ"

will check the bopomofo and turn into

phrase = "你好"
bopomofo = "ㄋㄧˇ(`U+3127`) ㄏㄠˇ"

By changing bopomofo-like character "一"(U+4E00) into "ㄧ"(U+3127).

But mis-typed the character take this feature down.

This commit fixes this.

qas612820704 commented 7 years ago

Also let 丫 will turn into ㄚ.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 94.915% when pulling 338c91e3e29a235381b61409e32c1389eddd6721 on qas612820704:master into 16792669286670d1dfef5589628828e9ea16e619 on chewing:master.

david50407 commented 7 years ago

Hi, I fixed this issue on #210 and merged into master. I'm going to close this PR now, if you have any question, you can re-open it. Thanks :)

qas612820704 commented 7 years ago

@david50407. That's OK! Thx :)