chewing / chewing-editor

Cross platform chewing user phrase editor
https://chewing.im/
GNU General Public License v2.0
30 stars 52 forks source link

add feature: user should not change the pronunciation of an alphabet #220

Open harryoooooooooo opened 7 years ago

harryoooooooooo commented 7 years ago

I add the feature discussing in #79.

Just check if the size of phrase and bopomofo are both 1, and also they are not the same, then the phrase shouldn't be a bopomofo.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 94.915% when pulling bcc6b5426de4729fb72f8180851570161c157b21 on harryoooooooooo:chewing-editor-issue79 into 16792669286670d1dfef5589628828e9ea16e619 on chewing:master.

david50407 commented 7 years ago

What if I typed "ㄅㄉ" with bopomofo "ㄇ ㄋ"? This case also try to create mistaken bopomofo of these words.

harryoooooooooo commented 7 years ago

I think we should not modify the pronunciation of a single alphabet. However, a combination of alphabet maybe occur a special meaning, so that user want to make it a phrase. we can discuss how chewing-editor should deal with it and have a consensus.

david50407 commented 7 years ago

The truth is though we added a phrase with impossible bopomofo, chewing still not provides these phrase according to its built-in bopomofo mapping.

So even we added a phrase "ㄅㄉ" with bopomofo "ㄇ ㄋ" in the editor, we still cannot type this phrase by the bopomofo we added. And the editor should avoid to adding all these invaild phrases not just this case.

harryoooooooooo commented 7 years ago

but actually I can type this phrase after I map "ㄅㄉ" to "ㄇ ㄋ". screenshot from 2017-04-16 13-04-51