search

chewing / chewing-editor

Cross platform chewing user phrase editor
https://chewing.im/
GNU General Public License v2.0
31 stars 52 forks source link

Fix remove phrase incorrect behavior #230

Closed hunghw closed 7 years ago

hunghw commented 7 years ago

Fixed #192 . Checking the selection phrases instead of only checking if there is no phrase. I squashed my commit, PR #200.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 94.915% when pulling 70522fa0f313b04f9c5e54926fbfde725190b825 on hwhung0111:patch-1 into 16792669286670d1dfef5589628828e9ea16e619 on chewing:master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 94.915% when pulling 2ecc8212c20e6d4aa669f0427928e8bc1faa782c on hwhung0111:patch-1 into 16792669286670d1dfef5589628828e9ea16e619 on chewing:master.

david50407 commented 7 years ago

Squash your commits first.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 94.915% when pulling 4d258cea161bdde03c998a13e0cc82dadde83177 on hwhung0111:patch-1 into 16792669286670d1dfef5589628828e9ea16e619 on chewing:master.

hunghw commented 7 years ago

@david50407 I have squashed my commits.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 94.915% when pulling 6788f360f7d5c51885e5e11d892627ceefee8cfa on hwhung0111:patch-1 into b32701cd81182ba27cfcea935ba2a21f8c3cd4c0 on chewing:master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 94.915% when pulling ca2c21f7f473ee74980de401e2f9e02f0df80b30 on hwhung0111:patch-1 into b32701cd81182ba27cfcea935ba2a21f8c3cd4c0 on chewing:master.

jserv commented 7 years ago

Commit message "check the selection phares are bigger than one" is not valid English expression.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 94.915% when pulling 89bc78fc5803f1e63fd38e459d092c607bf61e85 on hwhung0111:patch-1 into b32701cd81182ba27cfcea935ba2a21f8c3cd4c0 on chewing:master.

jserv commented 7 years ago

Don't mention issue #192 in the subject of Git commit messages. Instead, do it within body.