chewjh1234 / pe

0 stars 0 forks source link

Gibberish is allowed #10

Open chewjh1234 opened 9 months ago

chewjh1234 commented 9 months ago

Gibberish (!@#$%^&) is allowed to be words in this application.

While I understand that there is no command input restriction, these are not words to begin with.

It should not be allowed in this application, which is meant for users to learn proper words.

Someone may have accidentally typed this !@#$% in, and presumed that this is an actual word when it isn't? This will hinder their progress of learning words.

Screenshot 2023-11-17 at 5.04.34 PM.png

soc-pe-bot commented 9 months ago

Team's Response

Like you said we mentioned that there is no command input restriction in our UG. Our product is designed to allow users to make their own flash cards as convenient as possible. In this case, any restriction on input is redundant and will further hinder users' operations on adding and editing the flash cards. In contrast, our current design of allowing full customizability fits with our product scope and ensures users can successfully make the flash cards they want.

We regard symbols as legal input. For instance, as a lazy user, I may want to learn the German word "Ausrufezeichen", which means the exclamation mark in English. Our app allows the user to add the flash card with a simple command add w/Ausrufezeichen t/!. However, if disabling symbol input, user's efficiency will decline and more importantly, the restriction will cause significant harm as it hinders user's legal operation.

Moreover, our app has provided a remedy if users wrongly input a word: they can use delete command to delete the card or edit the card.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement:

In this case, this feature has worked according to how you intended it to be, and it is not wrong per se. However, I was thinking about the value proposition of your application. Your team has stated that Flashlingo is an application that helps users to learn words.

Screenshot 2023-11-21 at 1.48.53 PM.png

In a duplicate that is linked to this bug report, users are able to add emojis, icons into the application as original and translated words. In the example you have given, add w/Ausrufezeichen t/!, you are passing off symbols as words, when in fact, add w/Ausrufezeichen t/exclamation would work equally well. In fact, that is the result Google translate gives me:

Screenshot 2023-11-21 at 5.21.55 PM.png

In many language-learning applications, the goal is to facilitate understanding and enhance users' language skills. Preventing the acceptance of gibberish or random characters as valid words can contribute to a more focused and effective learning environment.

While allowing symbols might enhance user efficiency, prioritising convenience and efficiency over proper vocabulary and language learning quality is detrimental. Overemphasis on convenience could lead to overlooking the importance of using real words in flashcards, potentially impacting the learning process.

Moreover, encouraging the use of actual words ensures accuracy and prevents the reinforcement of incorrect information about vocabulary terms.

Your team could have considered implementing measures to prevent or address the inadvertent use of non-words.

Therefore, I believe that this feature could have been implemented to work in a better way, and I consider this as a feature flaw.

I note the definition for a feature flaw here:

Screenshot 2023-11-21 at 2.30.13 PM.png

Screenshot 2023-11-21 at 2.31.47 PM.png


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]