chewjh1234 / pe

0 stars 0 forks source link

Constructor too long #25

Open chewjh1234 opened 12 months ago

chewjh1234 commented 12 months ago

Constructor is too long. Does not follow code Screenshot 2023-11-17 at 5.40.03 PM.png

nus-pe-bot commented 11 months ago

Team's Response

Which constructor and which part doesn't follow the code?

Items for the Tester to Verify

:question: Issue response

Team chose [response.IssueUnclear]

Reason for disagreement: Apologies. This was the last bug report I submitted, and time was up. I wasn't able to add more details.

I was referring to the YesCommand constructor.

According to the sequence diagram, parseCommand() from FlashlingoParser is called. Here is the relevant code from FlashlingoParser.java:

Screenshot 2023-11-21 at 9.04.31 PM.png

In the code above, you called the constructor YesCommand().

However, when I looked at YesCommand(), there is nothing in the function body:

Screenshot 2023-11-21 at 9.04.52 PM.png

The screenshot of the sequence diagram seems to suggest that methods such as nextReviewWord(), updateLevel(), recallFlashCard() etc. are called in the constructor. However, this is not the case. The constructor does not have any method or code in its body. This was why I said the constructor is too long and it "does not follow code".

I apologise that I wasn't able to add more details as time was up. But this was what I wanted to type for the original bug report.