search

chewjh1234 / pe

0 stars 0 forks source link

Invalid edits to words (not data format) made to JSON file causes loss of all data #3

Open chewjh1234 opened 11 months ago

chewjh1234 commented 11 months ago

When there are same words in the JSON file, such as:

Screenshot 2023-11-17 at 4.23.35 PM.png

The entire file gets deleted.

This removed all the data and all data is lost.

In the UG, it is stated that this happens only when there is invalid command format, not invalid data.

Screenshot 2023-11-17 at 4.24.27 PM.png

The words I entered (albeit in different cases) are not invalid words in the wrong format

Actual result: Screenshot 2023-11-17 at 4.24.30 PM.png

soc-pe-bot commented 11 months ago

Team's Response

As #243, #304 stated in the forum, handling invalid data in the JSON file is not a requirement and failing to do so shouldn't be considered as a bug, only running the app with correct data needs to be supported. As you've mentioned, the behavior that causes the situation of all data to be clear is an "invalid edit", thus any consequence regarding this invalid data should not be in consideration.

Moreover, we've mentioned in planned enhancement 5 that we'll provide more error handling when failing to load the data file. This enhancement would prevent the situation mentioned here as the app will give user chance to correct the invalid data.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]