search

chewjh1234 / pe

0 stars 0 forks source link

Able to add empty original words #4

Open chewjh1234 opened 10 months ago

chewjh1234 commented 10 months ago

In the UG, it is clearly stated that empty words are not allowed to be added.

Word/translation cannot be empty!

But I am able to do so through edits to JSON file 

 {
    "originalWord" : "",
    "originalWordLanguage" : "English",
    "translatedWord" : "闪邻国",
    "translatedWordLanguage" : "Chinese",
    "whenToReview" : "2023-11-17T08:28:48Z",
    "level" : 1
  }

Screenshot 2023-11-17 at 4.31.02 PM.png

nus-pe-script commented 10 months ago

Team's Response

As #243, #304 stated in the forum, handling invalid data in the JSON file is not a requirement and failing to do so shouldn't be considered as a bug.

Thus, only running the app with correct data needs to be supported. Since our product restricts that "Word/translation cannot be empty", the empty originalWord in the JSON file is invalid and any app behavior related to this should not be in consideration.

Moreover, we've mentioned in planned enhancement 5 that we'll provide more error handling when failing to load the data file. This enhancement would prevent the situation mentioned here as the app will give user chance to correct the invalid data.

error handling regarding invalid data input:

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]

## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]