chewjh1234 / pe

0 stars 0 forks source link

Ambiguity when the translated word appears in the command box #9

Open chewjh1234 opened 12 months ago

chewjh1234 commented 12 months ago

When the 'reveal' button is clicked, the translated word appears in the command box. However, it is unclear which original word it belongs to, especially when multiple words are clicked.

A better error message should state "The translated word of __ is ___."

For example:

Screenshot 2023-11-17 at 5.00.22 PM.png

soc-se-bot commented 11 months ago

Team's Response

In order to click the button, you must be able to see the flashcard that has the button. Therefore you will by extension know which flashcard you had revealed the translation for. Even if the word is not seen as in the picture above, you will still know which flashcard it is for and simply be able to scroll up to view it.

To use the reveal command without the GUI, you must be able to see the index, which is next to the original word. Therefore, this is not a limitation as it is simply assuming you would use the reveal button the same way you would the CLI, with knowledge of what flashcard you are revealing.

Thanks for the suggestion however.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: > In order to click the button, you must be able to see the flashcard that has the button. Therefore you will by extension know which flashcard you had revealed the translation for.

I agree with this statement.

However, users will know the flashcard they have revealed the translation for at that point in time only. It does not discount the fact that users are able to scroll away from the flashcard to view other flashcards. Once the users have scrolled away to view other flashcards, the translated word that remains in the command box becomes irrelevant. This may baffle users as they may be unclear of the original word that the translated word belongs to.

Even if the word is not seen as in the picture above, you will still know which flashcard it is for and simply be able to scroll up to view it.

Think about the English language. It has around 170,000 words in current use, with an additional 47,000 obsolete words.

Your application is one which allows users to learn the words of a new language. This also means that users can add a large number of words into your application (it could be hundreds or even thousands of words). It is not as easy as scrolling up to search for the original word, as you would have to plough through, in the worst case scenario, hundreds or thousands of words to look for the correct original word.

To use the reveal command without the GUI, you must be able to see the index, which is next to the original word.

Not true. Assuming that there are at least 100 flashcards, I could enter reveal 100 without seeing the flashcard containing the index '100' and the original word.

Therefore, this is not a limitation as it is simply assuming you would use the reveal button the same way you would the CLI, with knowledge of what flashcard you are revealing

This is also a problem. It is not stated in the UG that the prerequisite for using the reveal command is that I should know which flashcards I am revealing. Therefore, you should not assume that I know the flashcard I am revealing when I enter reveal 100, or assume that I remember the original word when in fact, I have scrolled far away from the flashcard containing the original word in concern.

I note the definition for a feature flaw:

Screenshot 2023-11-21 at 2.30.13 PM.png

Screenshot 2023-11-21 at 2.31.47 PM.png

Specifically, your team did not consider cases where:

In the original bug report, I gave a suggestion on how the problems mention above could be solved and this feature made much better by giving a message like this instead:

"The translated word of __ is ___."

And this message could be implemented without much additional effort.

Therefore, it is still a valid FeatureFlaw of severity.Low