search

chews0n / glowing-waffle

SPE Calgary Data Science Mentorship program 2021
Apache License 2.0
1 stars 2 forks source link

Tmoore #3

Closed tomwmoore closed 3 years ago

tomwmoore commented 3 years ago

Weather EDA and Prediction Model

chews0n commented 3 years ago

Looks good, there wasn't a specific requirement and I had the same note for Harrison, but just in general when you write code, try to make it as universal as possible, eg. when reading in your csv files, make a function to loop over the csv files and have the csv files fed into the script as an input (preferably from the command line where you give it a path to search for the data files). I made a few of those changes on Harrison's work if you want to take a look as an example.

But yah, liked the code, it could have been a little more concise, but I realize you were outputting a lot to tell the code story. Plot looks great too, great labels. newplot