search

chewterence / pe

0 stars 0 forks source link

software failed to load from json file when json file was edited to have duplicate names #5

Open chewterence opened 3 years ago

chewterence commented 3 years ago

Certain users might be able to go and change the data within the .json file to contain the same names, causing the file to not load when there are duplicates

Steps to reproduce: edit heymatez.json to contain the same names.

image.png

image.png

nus-pe-bot commented 3 years ago

Team's Response

As stated in the UG, HEY MATEz will discard all data and start with an empty data file at the next run if the data is invalid. Having members with duplicate names is considered invalid.

However editing of json files is still allowed for advanced users to make changes to the data quickly but they still have to do it within the constraints of the software and at their own risk of introducing invalid data. \

Hence this is not an issue

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Thank you for the response.

While I agree that "editing of json files is still allowed for advanced users to make changes to the data quickly", but i believe that incorrect edits of json files should at least be caught/warned (perhaps even prompting the user to delete/reset the data file), instead of causing the program to not load, leaving the user confused.

Hence, i believe that this bug should be accepted.

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Medium]

Reason for disagreement: This bug is a flaw that causes occasional inconvenience to some users but they can continue to use the product. Some users being the "advanced users" who edited the json file.