search

chewterence / pe

0 stars 0 forks source link

Editing name in .json file causes software to not load. #7

Open chewterence opened 3 years ago

chewterence commented 3 years ago

Steps to reproduce: from the application's first boot edit the .json file "Bernice Yu" to "Sheesh" reload the application

image.png

nus-pe-bot commented 3 years ago

Team's Response

The reason why this happened is because tester the likely changed the name without changing the assignee name "Bernice Yu" too. This is why the json file got wiped as changing Bernice Yu only without changing the assignees tagged as Bernice Yu results in an invalid data file (you get a ghost assignee), where there is no Member called "Bernice Yu" anymore but you have tasks still assigned to "Bernice Yu". As stated in the UG, HEY MATEz will discard all data and start with an empty data file at the next run if the data is invalid

If you wish to change the name via json, you have to change the member name and the assignee name under the tasks, which works as shown below (Change all "Bernice Yu"s in assignee names to "Sheesh" too, in the tester's case)

Changed member name without changing assignees with the same name (Incorrect way): image.png

json file with tasks as old member name as assignee (Incorrect way): image.png

Result: Blank data as tester showed

However, if you change the assignee names accordingly too:

Result (Done the correct way): image.png

As shown above, the names are changed correctly and this is not an issue as the tester made the data file invalid

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Thank you for the response and explanation on why the bug occured.

While I agree that "editing of json files is still allowed for advanced users to make changes to the data quickly", but i believe that incorrect edits of json files should at least be caught/warned (perhaps even prompting the user to delete/reset the data file), instead of causing the program to not load, leaving the user confused.

You have demonstrated the right way to do this json edit. However, in the case of an advanced user who has made the wrong edit, they would be left confused on at which part did their edits go wrong. Therefore, a suggestion is to either restrict the editing of json data, or to at least perform validation of the json data when loading.

Hence, i believe that this bug should be accepted.

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Medium]

Reason for disagreement: This bug is a flaw that causes occasional inconvenience to some users but they can continue to use the product. Some users referring to "advanced users" who have edited the json file.