chewterence / pe

0 stars 0 forks source link

able to add members of different names, but same phone and email #8

Open chewterence opened 3 years ago

chewterence commented 3 years ago

steps to reproduce: addMember Dylan p/64529356 e/dylan@gmail.com addMember Dylann p/64529356 e/dylan@gmail.com addMember Dylannnn p/64529356 e/dylan@gmail.com

image.png

phone numbers and email addresses should be unique and detected by this program. This way, any task created could have 3 dylans spelt differently but have exactly the same details such as email and phone number.

nus-pe-bot commented 3 years ago

Team's Response

Members are identified by name and nothing else. Hence it is allowed. Phone numbers and emails need not be unique

An example of when phone numbers and email need not be unique is when members are from the same workplace / department, eg SoC office. Workers may use the common office hotline / email in this app. E.g. common SoC enquiry email (soc@nus.edu.sg) and telephone number 6516 2727. Restricting this would prevent valid and different members from being added as the different details might want to use their work contact details (SoC general email and hotline)

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Thank you for the response.

While I agree with your claim that "Workers may use the common office hotline / email", but you have defined your target users to be CCA club leader, and it is highly unlikely they would have their own office hotline or even common enquiry email. image.png

Moreover, duplicate members should not be identified solely by their names. This is a major flaw of this product that I have identified in the feedback. Back in my boy scouts CCA, I had two "Alan Goh" scouts and this would make it impossible for me to use this product.


:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.High]

Reason for disagreement: Most emails and phone numbers in this case (for users who are students), should already be unique. Two students should not able to have the same emails and phone numbers.

This application allowed the addition of the two fields to be non-unique, and thus should warrant at least a "Medium" as it is a flaw that causes occasional inconvenience to some users but they can continue to use the product.