search

chewterence / pe

0 stars 0 forks source link

able to add almost duplicate name #9

Open chewterence opened 3 years ago

chewterence commented 3 years ago

add the name "dylan n" and "dylan n"

steps to reproduce: addMember dylan n p/64529356 e/dylan@gmail.com addMember dylan n p/64529356 e/dylan@gmail.com

image.png

nus-pe-bot commented 3 years ago

Team's Response

As the tester mentioned, the names are almost duplicate - they are not duplicates, hence its allowed. UG also specified name is format sensitive - “spacing” matters and the spacing between the names itself.

This is because 1. it is too tedious and to check, parse and trim all whitespaces within the names, it will result in bloated code if such checking is done. 2. There should only be 1 spacing between actual names, conventionally people do not put multiple spaces in between names. 3. If people choose to use nicknames here the spacing will matter

We also make it format-sensitive (spacing matters) to use spacing is a possible solution to differentiate 2 people of the same name (nickname approach)

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Thank you for the response and explanation.

I will start by first addressing your three-pointers below:

  1. it is too tedious and to check, parse and trim all whitespaces within the names, it will result in bloated code if such checking is done. It being too tedious to check, parse and trim all whitespaces and resulting in bloated code is a problem for the software engineers. The role of the software engineer is to ensure that most bugs, even this, should be caught and handled properly. Tediousness should not be a reason why this bug was not caught. Moreover, if you apply proper software engineering principles, the code should not be bloated.

  2. There should only be 1 spacing between actual names, conventionally people do not put multiple spaces in between names. This may be true, but what about in the case of a typo? What if the user meant to enter "Dylan tan" and even another "Dylan tan" but with a whitespace. image.png This could potentially cause confusion for the user as he/she might or might not have intended to enter "Dylan tan" twice.

  3. If people choose to use nicknames here the spacing will matter You have agreed that spacing will matter. If there is this functionality "We also make it format-sensitive (spacing matters) to use spacing is a possible solution to differentiate 2 people of the same name (nickname approach)", it would not defeat the purpose of the way that duplicates are defined in this software.

In conclusion, duplicates are defined by people with the same names in this program, and one is able to enter "Dylan tan" and "Dylan tan", two exact same names but only a difference of white space.

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.High]

Reason for disagreement: This should not be downgraded to "Very low". For the arguments that i have stated above, this should at least warrant a "Low" or a "Medium".