search

chewypiano / pe

0 stars 0 forks source link

routine_view functionality error (invalid routine error when it exists) #5

Open chewypiano opened 3 years ago

chewypiano commented 3 years ago

Routine_view (from UG and DG) simply requires routine index to exist to work. However, when we try filter the routines using routine_find someInvalidName, routine_view stops working.

Recreated below: Type routine_find unknowRoutine (given unknowRoutine does not exist in list, if it does just pick a name which does not exist) and hit enter. As expected, Routines section will show 0 routines as shown below:

Screenshot 2020-11-13 at 5.01.29 PM.png

Next, type routine_view 1 (given routine list has at least 1 routine, if it doesnt then just add a routine before trying this bug recreation altogether) and hit enter. We expect the first index routine to be displayed but instead we get an out of bounds error as shown below:

Screenshot 2020-11-13 at 4.59.03 PM.png

nus-se-bot commented 3 years ago

Team's Response

Hello, thank you for the feedback!

We have decided to reject this as a bug because it is stated in the UG that the routine_view is according to the index of the list, and not the overall listing of routines in fitNUS. Attached below is the snippet of our UG.

image.png

So the finding is by the index seen in the list. So, according to the UG, when you type in routine_view 1 for the above list after the find command when there are no items at all, this is an appropriate response. We do not believe this deviates from the UG at all. We hope we have clarified any doubts in this bug report.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Thank you for you response. I understand your sentiment but I disagree with it.

Firstly, your UG does not explicitly mention what list you are referring to. Lets first refer to the image below:

Screenshot 2020-11-18 at 9.03.31 PM.png

When we refer to your edit feature, the term displayed list is explicitly mentioned. However, when we refer to your routine_view feature, no mention of displayed list was made anywhere. In your explanation, it was mentioned view a certain routine in fitNUS indicated by the index. and in the example at index 2 in the list but no mention was made to which list you are referring to. If we take your edit example as the standard, there should then be a distinction between list and displayed list. As such, this would imply that the bug goes against the expected behaviour.

Secondly, your DG which is the document testers refer to, does not make any mention of the displayed_list limitation. Lets refer to the image below:

Screenshot 2020-11-18 at 9.10.49 PM.png

As is shown in the image above, the only prerequisite is that the routine must already exist in fitNUS which it does in my bug report. No mention is made to the routine having to be present in the filtered or displayed list. As such, this bug clearly, according to defintions and explanations in your UG and DG, deviates from the standard or expected behaviour.

I hope you understand my reasoning and gain greater clarity through this response. Thank you.

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: Thank you for your response.

I disagree with this change because your rejection did not elaborate at all on the need to change severity.

Furthermore, the reasoning behind the medium severity is because it fits the narrative "A flaw that causes occasional inconvenience to some users but they can continue to use the product" given in the notes. Finding a routine, and subsequently using the routine_view method should represent an occasional combination used in your application, and by extrapolation, an occasional inconvenience.

Thus, I tag it as medium.

Thank you, I hope you understand.