search

chflame163 / ComfyUI_LayerStyle

A set of nodes for ComfyUI that can composite layer and mask to achieve Photoshop like functionality.
MIT License
1.48k stars 84 forks source link

Not sure if this is a false positive but LDM model download reported as containing trojan (cond_stage_model_decode.pt) #120

Closed creeduk closed 5 months ago

creeduk commented 5 months ago

I have reported it on sansters github (the model source). You have a download call in:

https://github.com/chflame163/ComfyUI_LayerStyle/blob/main/py/iopaint/model/ldm.py

LDM_DECODE_MODEL_URL = os.environ.get( "LDM_DECODE_MODEL_URL", "https://github.com/Sanster/models/releases/download/add_ldm/cond_stage_model_decode.pt",

I ran this Saturday and the next full scan my PC did quarantined that file stating Trojan and Threat severe (Trojan:win32/Sirefef!cfg). Now the Trojan has been reported on reddit as being associated as  false positive with some SD related code. My report stated the containing file is cond_stage_model_decode.pt and the file is data/80.

I see no other related files. Thought as you reference this I better bring it to your attention you may want to confirm if it is a positive or if there is a different source, Hopefully sanster can remedy it in iopaint.

Not sure how to tell what it is attempting to do that might trigger that detection.
chflame163 commented 5 months ago

I'm not sure, it's probably a false alarm. The source code is original of iopaint package, I just embedded it.

creeduk commented 5 months ago

Defender will automatically remove the file. Hopefully Sanster can shed light in it like who trained it. For now I will just forgo that Lama Model, no need to take a risk just in case..