chflame163 / ComfyUI_LayerStyle

A set of nodes for ComfyUI that can composite layer and mask to achieve Photoshop like functionality.
MIT License
1.58k stars 91 forks source link

Excessive disk space usage with Kijai Florence2 pack #323

Open freshwind-bit opened 1 month ago

freshwind-bit commented 1 month ago

Your wonderful custom node pack and Kijai Florence2 pack install the same models in different folders: Florence2 and LLM. Because of this, a lot of disk space is wasted. In my opinion, it is much more logical to store models in the LLM folder in subfolders with the Florence-2- prefix, as Kijai did. https://github.com/kijai/ComfyUI-Florence2

chflame163 commented 1 month ago

Also other plugins that put models into models/Florence2, like https://github.com/yiwangsimple/florence_dw. Of course, you can make soft link between these model folders to save space.

freshwind-bit commented 1 month ago

In your nodes, the Phi-3.5 models are loaded into the LLM folder. Why are Florence2 models moved to a higher level? And the other pack you mentioned is not in the ComfyUI manager at all and you are mistaken - there the models are loaded into Florence, not the Florence2 folder, here is a quote: "manual download to comfyui/models/florence/large(base,base-ft,large-ft,sd3)"

chflame163 commented 1 month ago

And the other pack you mentioned is not in the ComfyUI manager at all and you are mistaken - there the models are loaded into Florence, not the Florence2 folder, here is a quote: "manual download to comfyui/models/florence/large(base,base-ft,large-ft,sd3)"

His readme is incorrect, the code is this:

微信图片_20241002143326
freshwind-bit commented 1 month ago

@chflame163 I did it like this: https://github.com/kijai/ComfyUI-Florence2/issues/79#issuecomment-2404402346 But symlinks are not copied to backups. Duplicate files are copied in their place. So this is a crutch.