Damage values are occasionally slightly too high (+1~+3)

[Sauzels]

idk how worried you are about a couple of damage points or if this is the right way to tell you but

I've seen min roll damage in the game do less than the visualizer's reported minimum roll, apparently because gen IV damage calculation has more floors than the Empire State Building. From rooting around in Pokémon Showdown's damage calculator:

• The basic formula is Math.floor(Math.floor(Math.floor(2 * LEVEL / 5 + 2) * userBasePower * userAttack / 50) / foeDefense).
• STAB is applied before type effectiveness, with a flooring in the middle.
• Apparently in gen IV, it looks at the effectiveness against each of the defender's types individually and floors the result after each type. So if a move is NVE on the first type and SE on the second, each value is essentially rounded down to the nearest even number. Which means which type is primary/secondary actually very slightly matters in this game.

I probably won't see it if you respond to this thread here but you should be able to find my Discord on the TPP channel.

[chfoo]

Thanks, the calculation should be more accurate now. For the last point, I probably won't be fixing that since there isn't a demand for the visualizer to have rich and accurate battle engine interactivity. (While I would like that, I haven't had the time to make one like Dhason's and Showdown's code doesn't work well as a library I could use.)